Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: upgrade to deno_semver 0.7 #27426

Merged
merged 16 commits into from
Dec 20, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Dec 19, 2024

% hyperfine --warmup 5 "./deno_old install" "./deno_new install"
Benchmark 1: ./deno_old install
  Time (mean ± σ):     552.3 ms ±   4.8 ms    [User: 530.2 ms, System: 37.0 ms]
  Range (min … max):   547.7 ms … 562.2 ms    10 runs
 
Benchmark 2: ./deno_new install
  Time (mean ± σ):     523.2 ms ±   5.1 ms    [User: 502.1 ms, System: 33.9 ms]
  Range (min … max):   516.7 ms … 534.9 ms    10 runs
 
Summary
  ./deno_new install ran
    1.06 ± 0.01 times faster than ./deno_old install

Most of our time is spent deserializing packuments.

@dsherret dsherret marked this pull request as ready for review December 20, 2024 19:56
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't think we expect any changes in the benchmark page after this one lands?

@dsherret
Copy link
Member Author

Probably not. I don't think the benchmark page does any npm resolution. I'll add a benchmark to this PR description in a second.

@dsherret dsherret enabled auto-merge (squash) December 20, 2024 20:49
@dsherret dsherret merged commit ece718e into denoland:main Dec 20, 2024
17 checks passed
@dsherret dsherret deleted the refactor_deno_semver_0_7 branch December 20, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants