Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove now needless canonicalization getting closest package.json #27437

Merged

Conversation

dsherret
Copy link
Member

This is no longer required because we now store everything in the file system for deno compile instead of in an eszip.

Before:

Timer precision: 41 ns
bench          fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ resolution  217.7 µs      │ 715.5 µs      │ 227.2 µs      │ 233.4 µs      │ 1000    │ 1000

After:

Timer precision: 41 ns
bench          fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ resolution  191.1 µs      │ 768.7 µs      │ 198.2 µs      │ 205.4 µs      │ 1000    │ 1000

(My system is noisy, not doing a proper bench, but it removes some fs operations so going to be faster)

@dsherret dsherret merged commit 77e1af7 into denoland:main Dec 20, 2024
17 checks passed
@dsherret dsherret deleted the perf_remove_canonicalization_closest_pkg_json branch December 20, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants