refactor: split ops.rs #2753
Merged
refactor: split ops.rs #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
force-pushed
the
refactor-split_ops
branch
from
38e16c0 to
7026eaf
Compare
ry
reviewed
Aug 12, 2019
ry
reviewed
Aug 12, 2019
|
Looks good. I'm waiting on #2764 (and 0.14.1 release) before landing. |
Awesome, couldn't help myself to split all of them. I'll rebase after the release 👍 |
factor out 'files' ops factor out 'net' ops factor out 'workers' ops factor out 'compiler' ops factor out 'os' ops remove unneeded hyper imports factor out 'process' ops factor out 'repl' ops factor out 'permissions' ops factor out 'fs' ops fix rebase factor out 'fetch' and 'timers' ops factor out rest of ops remove unneeded pub modifiers
bartlomieju
force-pushed
the
refactor-split_ops
branch
from
a5d3dbb to
7c08d8d
Compare
ry
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #2730
This PR splits
//cli/ops.rsinto//cli/ops/module. I try to associate ops accordingly to their' counterparts in//js/(ref #2180)CC @ry