Remove dead code: legacy read/write ops #2776
Conversation
|
@ry in |
|
@bartlomieju thanks - fixed. |
ry
force-pushed
the
remove_dead_read_write
branch
from
636f45f to
e2ec9b7
Compare
| @@ -72,21 +69,23 @@ fn test_parse_min_record() { | |||
| assert_eq!(parse_min_record(&buf), None); | |||
| } | |||
|
|
|||
| pub fn dispatch_minimal( | |||
| pub type MinimalOp = dyn Future<Item = i32, Error = ErrBox> + Send; | |||
| pub type Dispatcher = fn(i32, Option<PinnedBuf>) -> Box<MinimalOp>; | |||
There was a problem hiding this comment.
I'm not a fan of this name. I always imagined "dispatcher" as a function which maps "op id" to "op handler".
There was a problem hiding this comment.
that's what this does (modulo the op id part)
There was a problem hiding this comment.
Mmmm, I'm not sure. It looks like Dispatcher is actually an "op", it returns MinimalOp which is the result of that op. I had a feeling that it was supposed to be that Dispatcher selects MinimalOp which returns some MinimalOpResult. But that's nomenclature... just thinking out loud
There was a problem hiding this comment.
Op = Promise = Future .. there are many ops for each dispatcher. An OpDispatcher (yet to be defined but outlined in #2730) is something that returns an Op.
So I think the term Dispatcher is appropriate here. That said, I consider this bit ephemeral as I plan on adding the OpDispatcher trait soon.
Seem to have caused master to go red. Cause unknown currently unknown, see denoland#2787. This reverts commit 498f6ad.
No description provided.