Internalize base64-js, convert to TypeScript #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
force-pushed
the
simplify_deps
branch
4 times, most recently
from
e01226b to
10a49bb
Compare
This is a regression on several some features in the fetch API. To bring these back @stardazed/streams simply needs to be ported to TS and included in the //js directory. Towards denoland#2608
|
I'm happy to help with streams, do you know how you want to handle those? |
|
@mrkurt Cool - so basically we just need to move it into //js rather than have it in node_modules... but the problem is I don't have support for I added an issue for this #2828 |
piscisaureus
approved these changes
Aug 28, 2019
|
Oh, probably don't even need a port, they're already typescript! https://github.com/stardazed/sd-streams/tree/master/packages/streams/src |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we improve our core bundling process, we will not be able to rely on external NPM modules.
Luckily there are only three of them:
Towards #2608