Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tools/build.py #2865

Merged
merged 18 commits into from
Sep 7, 2019
Merged

Remove tools/build.py #2865

merged 18 commits into from
Sep 7, 2019

Conversation

ry
Copy link
Member

@ry ry commented Sep 5, 2019 •
edited
Loading

Fixes #2608

Issues:

  • Doesn't run libdeno_test
  • This removes the ASAN build.
  • //BUILD.gn and //build are still in place. GN/Ninja should be limited to //core or //core/libdeno

ry added 5 commits September 5, 2019 11:54
@ry
WIP remove build.py
2224ae6
@ry
wip
2de19f2
@ry
WIP
aaba7cd
@ry
WIP
3205a24
@ry
rm -rf third_party/rust_crates
1c4a146 
This removes a lot of code...

 4920 files changed, 1925152 deletions(-)
@ry ry requested a review from piscisaureus September 5, 2019 16:11
piscisaureus
piscisaureus approved these changes Sep 7, 2019
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to land this.
Future improvements van be done in separate PRs.

@ry
Copy link
Member Author

ry commented Sep 7, 2019 •
edited
Loading

Alright - let’s do it! Good bye build.py

@ry ry merged commit acaff6d into denoland:master Sep 7, 2019
@ry ry mentioned this pull request Sep 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrmoritz chrmoritz chrmoritz left review comments

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cargo should be the main build frontend
3 participants
@ry @piscisaureus @chrmoritz