Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing import #2891

Closed
wants to merge 1 commit into from
Closed

Add missing import #2891

wants to merge 1 commit into from

Conversation

ry
Copy link
Member

@ry ry commented Sep 9, 2019 •
edited
Loading

I'm not sure how this isn't causing failures currently...

cc @nayeemrmn

@ry ry requested a review from piscisaureus September 9, 2019 14:32
@nayeemrmn
Copy link
Collaborator

nayeemrmn commented Sep 9, 2019 •
edited
Loading

@ry My mistake! That's in the testing context - of course It has access to runtime stuff (so this is just a case of #2888). Conversely the module shouldn't be using domTypes.Body but whatever it's exposed through in the proper userland globals... the problem being that it isn't exposed at all.

So I guess add export type Body = domTypes.Body; to globals.ts and refer to it as just Body in that test module. I think there are other interfaces exported in dom_types.ts that need to be exposed.

@nayeemrmn nayeemrmn mentioned this pull request Sep 10, 2019
Merged
@ry
Copy link
Member Author

ry commented Sep 10, 2019

Closed in favor of #2903

@ry ry closed this Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ry @nayeemrmn @piscisaureus