Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade v8 #2965

Closed
wants to merge 2 commits into from
Closed

Upgrade v8 #2965

wants to merge 2 commits into from

Conversation

ry
Copy link
Member

@ry ry commented Sep 16, 2019 •
edited
Loading

includes top-level-await

v8/v8@798cb90
#471

piscisaureus
piscisaureus approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please fix #2965 (comment)

@chrmoritz
Copy link
Contributor

chrmoritz commented Sep 17, 2019 •
edited
Loading

The /.cipd/ directory here comes from gclient installing CIPD dependencies and not from our third_party.download_from_cipd. But it was introduced with the depot_tools update for it.

Previously all binary dependencies were downloaded by gclient via a download_from_google_storage hook and we could skip that in sync_gclient.py by passing --no-hooks to gclient.

Unfortunately there doesn't seem to be a easy way to skip CIPD dependencies.

@ry
Copy link
Member Author

ry commented Sep 17, 2019

The top-level-await patch doesn't work yet - it's not yet in the parser. I should have read the commit message v8/v8@798cb90 more carefully.

I'll try to update another time.

@ry ry closed this Sep 17, 2019
@ry ry deleted the upgrade_v8 branch September 17, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ry @chrmoritz @piscisaureus