-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] tty: Deno.stdin.setRaw() #3947
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkassimo
force-pushed
the
tty/raw_mode
branch
from
February 10, 2020 02:05
b40be8d
to
52e062f
Compare
kevinkassimo
force-pushed
the
tty/raw_mode
branch
from
February 10, 2020 05:02
f0e47a6
to
467e405
Compare
kevinkassimo
force-pushed
the
tty/raw_mode
branch
from
February 10, 2020 05:25
467e405
to
dede7f1
Compare
Looks pretty good! Nice work! I'm adding @piscisaureus to review because I think he has some specific ideas about how TTY APIs should look. |
ry
reviewed
Feb 10, 2020
} | ||
|
||
// From https://github.com/kkawakam/rustyline/blob/master/src/tty/windows.rs | ||
// and https://github.com/crossterm-rs/crossterm/blob/e35d4d2c1cc4c919e36d242e014af75f6127ab50/src/terminal/sys/windows.rs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add their copyright header to this file. Something like this
// Copyright (c) 2015 Katsu Kawakami & Rustyline authors. MIT license.
Also #3958 over option 2 |
Closed in favor of #3958 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic implementation of raw mode for stdin. Implementation is tentative (op names unsure), and code is mostly lifted from crossterm or rustyline (without introducing more deps)
Likely won't work properly on Windows since I cannot test it locally.
Sample run (assume imput is
is raw
):