WIP: Allow multiple set-cookie headers

[Caesar2011]

Fixes #4826. The separator , is only allowed as a separator within Set-Cookie but not within other headers. This fix only works for Set-Cookie, the only standard-complient header witch is allowed to be set multiple times. Should this work for custom headers, too?

[CLAassistant]

All committers have signed the CLA.

[Caesar2011]

Just a tiny change, no reason why it should break, and only break on ubuntu...

[Caesar2011]

Before:

content-type: text/plain
set-cookie: user.session=qwertz; Max-Age=86400, a=123; Max-Age=86400, b=456; Max-Age=86400

After:

content-type: text/plain
set-cookie: user.session=qwertz; Max-Age=86400
set-cookie: a=123; Max-Age=86400
set-cookie: b=456; Max-Age=86400

[ry]

Thanks @Caesar2011 - I wonder if you could include a test?

[Caesar2011]

Sure, could you give me a short instruction how or at least where I can find similar tests?

Edit: I think I've got an idea.... Wait.... :D

[ry]

I don't think this regex is the optimal way of achieving this... I don't think any extra parsing should be necessary to write out the response.

[Caesar2011]

I am with you. No extra parsing should be necessary. But using the Headers construction with string[][] as parameter multiple headers get concatenated with , . You need some way to split it again, but not split within the expire value. (See comment in associated issue)

Do you have any suggestions/inspirations?

[marcosc90]

I found the same issue yesterday and started working on it, didn't know there was already work being done. I have a working implementation with a different approach, I'll reference this PR.

[marcosc90]

#4840

[Caesar2011]

Closed due to better approach in #4840