introduce unstable flag, make a few things unstable #4892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Apr 24, 2020
| /// This is intentionally a non-recoverable check so that people cannot probe | ||
| /// for unstable APIs from stable programs. | ||
| pub fn check_unstable(&self, api_name: &str) { | ||
| // TODO(ry) Maybe use IsolateHandle::terminate_execution here to provide a |
There was a problem hiding this comment.
Stack trace from TerminateExecution has no meaningful info - better to return error to JS (by adding new error kind) and throw it there
There was a problem hiding this comment.
I don't want it to be recoverable
There was a problem hiding this comment.
I agree - otherwise we will get modules that progressively enhance for unstable things. I think that is an antipattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimal version of #4639 where we only do a runtime check. Once this is working for a few ops, we can figure out how to also do type checking.
openPlugin, link, linkSync, symlink, symlinkSync now require --unstable flag
Ref #4334