Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: readTrailer didn't evaluate header names by case-insensitive #4902

Merged
merged 3 commits into from
May 29, 2020
Merged

fix: readTrailer didn't evaluate header names by case-insensitive #4902

merged 3 commits into from
May 29, 2020

Conversation

keroxp
Copy link
Contributor

@keroxp keroxp commented Apr 26, 2020

readTrailers() throws Undeclared trailer field if field name declared in trailer and actual field in trailer part is different in case-sensitive mode.

trailer: Deno, Node
...
deno: land
node: js

@bartlomieju bartlomieju added this to the std/0.53.0 milestone May 21, 2020
@bartlomieju bartlomieju removed this from the std/0.53.0 milestone May 29, 2020
bartlomieju
bartlomieju approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @keroxp

@bartlomieju bartlomieju merged commit b97459b into denoland:master May 29, 2020
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Jun 5, 2020
@keroxp @bartlomieju
fix: readTrailer didn't evaluate header names by case-insensitive (de…
60f225a 
…noland#4902)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@keroxp
fix: readTrailer didn't evaluate header names by case-insensitive (de…
fbf84dd 
…noland/deno#4902)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@keroxp
fix: readTrailer didn't evaluate header names by case-insensitive (de…
1ef460c 
…noland/deno#4902)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@keroxp @caspervonb
fix: readTrailer didn't evaluate header names by case-insensitive (de…
8d76d49 
…noland/deno#4902)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@keroxp @caspervonb
fix: readTrailer didn't evaluate header names by case-insensitive (de…
ecc1bf2 
…noland/deno#4902)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@keroxp @caspervonb
fix: readTrailer didn't evaluate header names by case-insensitive (de…
c59beb0 
…noland/deno#4902)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@keroxp @caspervonb
fix: readTrailer didn't evaluate header names by case-insensitive (de…
ff8fb9d 
…noland/deno#4902)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@keroxp @caspervonb
fix: readTrailer didn't evaluate header names by case-insensitive (de…
d9b7007 
…noland/deno#4902)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@keroxp @denobot
fix: readTrailer didn't evaluate header names by case-insensitive (de…
17d89c5 
…noland/deno#4902)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@keroxp @denobot
fix: readTrailer didn't evaluate header names by case-insensitive (de…
319cb90 
…noland/deno#4902)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keroxp @bartlomieju