-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename FileInfo time fields and represent them as Date objects #4932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Apr 27, 2020
piscisaureus
changed the title
Wip: rename FileInfo time fields and convert them to Date objects
Rename FileInfo time fields and represent them as Date objects
Apr 27, 2020
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Apr 27, 2020
…and#4932) This patch also increases the resolution of reported file times to sub-millisecond precision.
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Apr 27, 2020
…and#4932) This patch also increases the resolution of reported file times to sub-millisecond precision.
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Apr 27, 2020
…and#4932) This patch also increases the resolution of reported file times to sub-millisecond precision.
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Apr 27, 2020
…and#4932) This patch also increases the resolution of reported file times to sub-millisecond precision.
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Apr 27, 2020
…and#4932) This patch also increases the resolution of reported file times to sub-millisecond precision.
…and#4932) This patch also increases the resolution of reported file times to sub-millisecond precision.
ry
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Apr 27, 2020
For consistency, this PR also renames the `filename`' field in std's `WalkEntry` interface to just `name`. `WalkEntry` and `DirEntry` now have identical definitions, although `WalkEntry` contains full paths whereas `DirEntry` just contains the file name itself. Closes: denoland#4932
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Apr 27, 2020
For consistency, this PR also renames the `filename`' field in std's `WalkEntry` interface to just `name`. `WalkEntry` and `DirEntry` now have identical definitions, although `WalkEntry` contains full paths whereas `DirEntry` just contains the file name itself. Closes: denoland#4932
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Apr 27, 2020
For consistency, this PR also renames the `filename` field in std's `WalkEntry` interface to just `name`. `WalkEntry` and `DirEntry` now have identical definitions, although `WalkEntry` contains full paths whereas `DirEntry` just contains the file name itself. Closes: denoland#4932
SASUKE40
pushed a commit
to SASUKE40/deno
that referenced
this pull request
May 7, 2020
…and#4932) This patch also increases the resolution of reported file times to sub-millisecond precision.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 21, 2021
…and/deno#4932) This patch also increases the resolution of reported file times to sub-millisecond precision.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
…and/deno#4932) This patch also increases the resolution of reported file times to sub-millisecond precision.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
…and/deno#4932) This patch also increases the resolution of reported file times to sub-millisecond precision.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
…and/deno#4932) This patch also increases the resolution of reported file times to sub-millisecond precision.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
…and/deno#4932) This patch also increases the resolution of reported file times to sub-millisecond precision.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
…and/deno#4932) This patch also increases the resolution of reported file times to sub-millisecond precision.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
…and/deno#4932) This patch also increases the resolution of reported file times to sub-millisecond precision.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
…and/deno#4932) This patch also increases the resolution of reported file times to sub-millisecond precision.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
…and/deno#4932) This patch also increases the resolution of reported file times to sub-millisecond precision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch also increases the resolution of reported file times to sub-millisecond precision.