Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FileInfo time fields and represent them as Date objects #4932

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

piscisaureus
Copy link
Member

@piscisaureus piscisaureus commented Apr 27, 2020

This patch also increases the resolution of reported file times to sub-millisecond precision.

piscisaureus added a commit to piscisaureus/deno that referenced this pull request Apr 27, 2020
@piscisaureus piscisaureus changed the title Wip: rename FileInfo time fields and convert them to Date objects Rename FileInfo time fields and represent them as Date objects Apr 27, 2020
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Apr 27, 2020
…and#4932)

This patch also increases the resolution of reported file times to
sub-millisecond precision.
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Apr 27, 2020
…and#4932)

This patch also increases the resolution of reported file times to
sub-millisecond precision.
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Apr 27, 2020
…and#4932)

This patch also increases the resolution of reported file times to
sub-millisecond precision.
@ry ry mentioned this pull request Apr 27, 2020
43 tasks
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Apr 27, 2020
…and#4932)

This patch also increases the resolution of reported file times to
sub-millisecond precision.
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Apr 27, 2020
…and#4932)

This patch also increases the resolution of reported file times to
sub-millisecond precision.
…and#4932)

This patch also increases the resolution of reported file times to
sub-millisecond precision.
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piscisaureus piscisaureus merged commit ee4e6a1 into denoland:master Apr 27, 2020
@piscisaureus piscisaureus deleted the time branch April 27, 2020 19:40
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Apr 27, 2020
For consistency, this PR also renames the `filename`' field in std's
`WalkEntry` interface to just `name`. `WalkEntry` and `DirEntry` now
have identical definitions, although `WalkEntry` contains full paths
whereas `DirEntry` just contains the file name itself.

Closes: denoland#4932
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Apr 27, 2020
For consistency, this PR also renames the `filename`' field in std's
`WalkEntry` interface to just `name`. `WalkEntry` and `DirEntry` now
have identical definitions, although `WalkEntry` contains full paths
whereas `DirEntry` just contains the file name itself.

Closes: denoland#4932
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Apr 27, 2020
For consistency, this PR also renames the `filename` field in std's
`WalkEntry` interface to just `name`. `WalkEntry` and `DirEntry` now
have identical definitions, although `WalkEntry` contains full paths
whereas `DirEntry` just contains the file name itself.

Closes: denoland#4932
SASUKE40 pushed a commit to SASUKE40/deno that referenced this pull request May 7, 2020
…and#4932)

This patch also increases the resolution of reported file times to
sub-millisecond precision.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
…and/deno#4932)

This patch also increases the resolution of reported file times to
sub-millisecond precision.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
…and/deno#4932)

This patch also increases the resolution of reported file times to
sub-millisecond precision.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
…and/deno#4932)

This patch also increases the resolution of reported file times to
sub-millisecond precision.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
…and/deno#4932)

This patch also increases the resolution of reported file times to
sub-millisecond precision.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
…and/deno#4932)

This patch also increases the resolution of reported file times to
sub-millisecond precision.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
…and/deno#4932)

This patch also increases the resolution of reported file times to
sub-millisecond precision.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
…and/deno#4932)

This patch also increases the resolution of reported file times to
sub-millisecond precision.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
…and/deno#4932)

This patch also increases the resolution of reported file times to
sub-millisecond precision.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
…and/deno#4932)

This patch also increases the resolution of reported file times to
sub-millisecond precision.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants