Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check_state from isatty op #4937

Merged
merged 3 commits into from
Apr 29, 2020
Merged

Remove check_state from isatty op #4937

merged 3 commits into from
Apr 29, 2020

Conversation

hqnna
Copy link
Contributor

@hqnna hqnna commented Apr 27, 2020

Change op_isatty to stable by removing state.check_state("Deno.isatty"); as per #4933

Remove check_state from isatty op
2f0bbae 
Change `op_isatty` to stable by removing `state.check_state("Deno.isatty");`
@ry ry mentioned this pull request Apr 27, 2020
Closed
43 tasks
ry
ry approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check that isatty is not marked unstable in cli/js/lib.deno.ns.d.ts otherwise LGTM. Thanks!

@hqnna
Copy link
Contributor Author

hqnna commented Apr 27, 2020

Please check that isatty is not marked unstable in cli/js/lib.deno.ns.d.ts otherwise LGTM. Thanks!

will check that now.

bartlomieju
bartlomieju approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bartlomieju bartlomieju merged commit 2337fca into denoland:master Apr 29, 2020
SASUKE40 pushed a commit to SASUKE40/deno that referenced this pull request May 7, 2020
@SASUKE40
Make Deno.isatty stable (denoland#4937)
8147ed6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hqnna @ry @bartlomieju