Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make unix sockets require allow-write #4939

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Make unix sockets require allow-write #4939

merged 1 commit into from
Apr 27, 2020

Conversation

lucacasonato
Copy link
Member

Towards #4933

ry
ry approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - looks good

@ry ry merged commit 95a0885 into denoland:master Apr 27, 2020
@ry ry mentioned this pull request Apr 27, 2020
Closed
43 tasks
@bartlomieju
Copy link
Member

Is there a test exercising this permission check?

SASUKE40 pushed a commit to SASUKE40/deno that referenced this pull request May 7, 2020
@lucacasonato @SASUKE40
Make unix sockets require allow-write (denoland#4939)
1ae7daf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacasonato @bartlomieju @ry