Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: factor out datagram listeners, make them unstable #4968

Merged
merged 5 commits into from
Apr 28, 2020
Merged

refactor: factor out datagram listeners, make them unstable #4968

merged 5 commits into from
Apr 28, 2020

Conversation

bartlomieju
Copy link
Member

No description provided.

@ry ry mentioned this pull request Apr 28, 2020
Closed
43 tasks
ry
ry approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @bartlomieju

@bartlomieju bartlomieju changed the title [WIP] split datagram listeners refactor: factor out datagram listeners, make them unstable Apr 28, 2020
@bartlomieju bartlomieju merged commit 1b6181e into denoland:master Apr 28, 2020
@bartlomieju bartlomieju deleted the split_datagram_listeners branch April 28, 2020 19:46
SASUKE40 pushed a commit to SASUKE40/deno that referenced this pull request May 7, 2020
@bartlomieju @SASUKE40
refactor: factor out datagram from Deno.listen(), make it unstable (d…
47f5868 
…enoland#4968)

This commit changes Deno.listen() API by factoring out datagram listeners to Deno.listenDatagram(). New Deno.listenDatagram() is unstable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @ry