refactor: Rewrite LocalInspectorSession for node:inspector support
#883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #883 +/- ##
==========================================
- Coverage 81.43% 81.22% -0.22%
==========================================
Files 97 98 +1
Lines 23877 24882 +1005
==========================================
+ Hits 19445 20211 +766
- Misses 4432 4671 +239 ☔ View full report in Codecov by Sentry. |
bartlomieju
commented
Aug 24, 2024
| fn drop(&mut self) { | ||
| eprintln!("Dropping LocalInspectorSessionRaw"); | ||
| } | ||
| } | ||
| /// A local inspector session that can be used to send and receive protocol messages directly on | ||
| /// the same thread as an isolate. | ||
| pub struct LocalInspectorSession { |
There was a problem hiding this comment.
This struct should probably be let go from deno_core, but I'm still weighing it. node:inspector needs low level access to handle notifications/message response it self, but REPL, Jupyter and HMR runner rely on high-level API to await responses when posting.
|
Closing in favor of #938 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.