Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: rewrite action README #253

Merged
merged 6 commits into from
Feb 26, 2024
Merged

doc: rewrite action README #253

merged 6 commits into from
Feb 26, 2024

Conversation

FuriouZz
Copy link
Contributor

@FuriouZz FuriouZz commented Feb 2, 2024

Full rewrite of action/README.md

  • Document every inputs
  • Document include and exclude inputs, there were missing
  • Split readme into Usage and Examples
  • List every sections into a table of content
  • Repair broken links (automatic mode)

@CLAassistant
Copy link

CLAassistant commented Feb 2, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@arnauorriols arnauorriols self-requested a review February 6, 2024 13:11
arnauorriols
arnauorriols reviewed Feb 6, 2024
View reviewed changes
Copy link
Member

@arnauorriols arnauorriols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work! A couple of comments to refine the content and we'll be able to merge this

action/README.md Outdated Show resolved Hide resolved
action/README.md Outdated Show resolved Hide resolved
action/README.md Show resolved Hide resolved
action/README.md Outdated Show resolved Hide resolved
action/README.md Outdated Show resolved Hide resolved
action/README.md Outdated Show resolved Hide resolved
@FuriouZz
Copy link
Contributor Author

Hello @arnauorriols 👋
Do this PR need more changes?

@arnauorriols
Copy link
Member

Hello @arnauorriols 👋 Do this PR need more changes?

Nope, everything looks good!

@arnauorriols arnauorriols enabled auto-merge (squash) February 20, 2024 09:51
auto-merge was automatically disabled February 22, 2024 10:23

Head branch was pushed to by a user without write access

@arnauorriols arnauorriols merged commit 76baf28 into denoland:main Feb 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnauorriols arnauorriols arnauorriols approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FuriouZz @CLAassistant @arnauorriols