Various scope fixes and a failing test for an open bug #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piscisaureus
changed the title
ry
reviewed
May 31, 2020
| // `hs2` and not in `hs1` as specified. When this local is accessed, which is | ||
| // after `hs2` is destroyed, a crash happens. | ||
| // #[test] | ||
| // fn handle_scope_early_drop() { |
There was a problem hiding this comment.
In the future use #[ignore] so we continue checking that it compiles until it can be fixed
There was a problem hiding this comment.
Makes sense, thanks.
I had no idea that existed.
|
It seems that I forgot to commit a bunch of files that should have been included in 8213c0e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.