Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v8::StackTrace::CurrentStackTrace() bindings #800

Merged
merged 4 commits into from
Dec 28, 2021

Conversation

AaronO
Copy link
Contributor

@AaronO AaronO commented Oct 7, 2021

I originally added this binding to experiment with stacktrace stitching in deno, but as I suspected it's way too slow ...

Might be good to add for completeness sake or other use-cases ...

Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful addition but needs a test.

src/binding.cc Outdated Show resolved Hide resolved
src/exception.rs Outdated Show resolved Hide resolved
@crowlKats
Copy link
Member

Need this for denoland/deno#1725

@AaronO AaronO force-pushed the feat/current-stack-trace branch from d6a76be to e225226 Compare December 28, 2021 11:15
@CLAassistant
Copy link

CLAassistant commented Dec 28, 2021

CLA assistant check
All committers have signed the CLA.

@AaronO AaronO merged commit b3e09e6 into main Dec 28, 2021
@AaronO AaronO deleted the feat/current-stack-trace branch December 28, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants