Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo: add JSDoc examples to simple functions #492

Closed
5 tasks
iuioiua opened this issue Sep 4, 2023 · 8 comments
Closed
5 tasks

todo: add JSDoc examples to simple functions #492

iuioiua opened this issue Sep 4, 2023 · 8 comments
Assignees
Labels
good first issue Good for newcomers v1

Comments

@iuioiua
Copy link
Contributor

iuioiua commented Sep 4, 2023

Most functions in /utils are simple functions that could do with a little documentation. Objectives:

  1. Provide a short description of what the function does and/or its purpose.
  2. Provide an @example snippet.
  3. Keep It Simple, Stupid (KISS)
  4. Link to relevant documentation, if needed.

Targets:

  • /utils/db.ts
  • /utils/http.ts
  • /utils/islands.ts
  • /utils/payments.ts
  • /utils/posts.ts
@iuioiua iuioiua added good first issue Good for newcomers v1 labels Sep 4, 2023
@Nkiriobasi
Copy link

I’ll work on this

@iuioiua
Copy link
Contributor Author

iuioiua commented Sep 4, 2023

Great! I think it'd be best if we tackled this in chunks - like one PR per file.

@Nkiriobasi
Copy link

Alright, that’s fine

@Nkiriobasi
Copy link

Please I made two file changes in the first PR, it wasn’t intentional.

@roberto-morado
Copy link
Contributor

I see 👀 there are some functions still, I would like to work on this as well.

@iuioiua could you assign me to this?

@iuioiua iuioiua self-assigned this Sep 10, 2023
@iuioiua
Copy link
Contributor Author

iuioiua commented Sep 10, 2023

Hi @roberto-morado, I realised it'd be best if I were the one to work on this one, given I know the context and nuances behind a lot of this functionality. I assigned myself to make this clear. Thanks anyway for offering!

@roberto-morado
Copy link
Contributor

No problem 👍

@iuioiua
Copy link
Contributor Author

iuioiua commented Sep 21, 2023

This has been completed in a number of the related PRs.

@iuioiua iuioiua closed this as completed Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers v1
Projects
None yet
Development

No branches or pull requests

3 participants