feat: support https proxy #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mura-Mi
force-pushed
the
http_proxy
branch
2 times, most recently
from
2f61fad
to
79527bf
Compare
Mura-Mi
commented
Oct 5, 2024
Comment on lines
+201
to
+204
| // dispatcher is `ProxyAgent | undefined`, which is assignable to `Dispatcher | undefined` because | ||
| // ProxyAgent extends Dispatcher, but TS2322 is reported. | ||
| // @ts-ignore: | ||
| { dispatcher }, |
There was a problem hiding this comment.
Without this, following ts error is shown.
error: TS2322 [ERROR]: Type 'ProxyAgent | undefined' is not assignable to type 'Dispatcher | undefined'.
Property 'compose' is missing in type 'ProxyAgent' but required in type 'Dispatcher'.
undici's ProxyAgent extends undici's Dispatcher, so it seems false-positive.
Is this @ts-ignore acceptable?
|
gonna convert to reviewable after testing behind proxy next monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #83