fix(std/testing): equals does not differentiate undefined/absent keys (…

…#849)
denoland · Apr 14, 2021 · 7e4d6ef · 7e4d6ef
1 parent da2de64
commit 7e4d6ef
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/testing/asserts.ts b/testing/asserts.ts
@@ -161,6 +161,9 @@ export function equal(c: unknown, d: unknown): boolean {
         if (!compare(a && a[key as Key], b && b[key as Key])) {
           return false;
         }
+        if (((key in a) && (!(key in b))) || ((key in b) && (!(key in a)))) {
+          return false;
+        }
       }
       seen.set(a, b);
       return true;

diff --git a/testing/asserts_test.ts b/testing/asserts_test.ts
@@ -147,6 +147,12 @@ Deno.test("testingEqual", function (): void {
       new URL("https://example.test/with-path"),
     ),
   );
+  assert(
+    !equal({ a: undefined, b: undefined }, { a: undefined, c: undefined }),
+  );
+  assert(
+    !equal({ a: undefined, b: undefined }, { a: undefined }),
+  );
 });
 
 Deno.test("testingNotEquals", function (): void {