Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement fs-extra api for fs modules #261

Closed
12 of 13 tasks
axetroy opened this issue Mar 11, 2019 · 11 comments
Closed
12 of 13 tasks

implement fs-extra api for fs modules #261

axetroy opened this issue Mar 11, 2019 · 11 comments

Comments

@axetroy
Copy link
Contributor

axetroy commented Mar 11, 2019

fs-extra is a useful tool to process file. most of node library depends on it.

suffice to say that it is very useful.

I am going to implement it with deno.

@zekth
Copy link
Contributor

zekth commented Mar 11, 2019

Another idea would be to add rimraf function? like rm -rf ?

@shisama
Copy link
Contributor

shisama commented Mar 13, 2019

Another idea would be to add rimraf function? like rm -rf ?

Is it await Deno.remove("/path/to/dir", {recursive: true}); ?

https://deno.land/typedoc/index.html#remove

@zekth
Copy link
Contributor

zekth commented Mar 13, 2019

You're right my bad

@axetroy
Copy link
Contributor Author

axetroy commented Mar 13, 2019

I think we should alias Deno.remove to fs.remove .

avoid switch API between Deno and fs

fs.remove(); // same with Deno.remove()

@zekth
Copy link
Contributor

zekth commented Mar 14, 2019

Add in the task list : Write the readme.MD of the module.

Would you want me to write it?

@axetroy
Copy link
Contributor Author

axetroy commented Mar 14, 2019

@zekth ok, you do it

@GrosSacASac
Copy link
Contributor

Hi please consider adding safe delete (move to trash-bin)

@zekth
Copy link
Contributor

zekth commented Mar 18, 2019

Hi please consider adding safe delete (move to trash-bin)

I think move to trash bin may have it's place in another repository instead of being into the std lib.

@zekth
Copy link
Contributor

zekth commented Mar 18, 2019

Adding this for readfilestr ref: #276

@lisniuse
Copy link

I think that shortcuts like fs-extra should be placed in a non-standard library.

@axetroy
Copy link
Contributor Author

axetroy commented Apr 7, 2019

@GrosSacASac
sorry for late response.

move to trash have third party dependence. it should not add to std.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants