-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fs): add copy/copySync #278
Conversation
I am implementing copy link file Here's a problem:
|
/cc @ry ready for review |
By the way Because the test files are too large and difficult to review. Is it possible to separate synchronous and asynchronous tests? // copy_test.ts
import "./copy_async_test.ts"
import "./copy_sync_test.ts" |
@axetroy I don't mind big files. I'd prefer you keep related code together. But I leave it up to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - nice work!
part of #261