Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fs): add copy/copySync #278

Merged
merged 30 commits into from
May 16, 2019
Merged

feat(fs): add copy/copySync #278

merged 30 commits into from
May 16, 2019

Conversation

axetroy
Copy link
Contributor

@axetroy axetroy commented Mar 14, 2019

part of #261

@axetroy axetroy mentioned this pull request Mar 14, 2019
13 tasks
fs/copy.ts Outdated Show resolved Hide resolved
fs/copy.ts Outdated Show resolved Hide resolved
@axetroy
Copy link
Contributor Author

axetroy commented Mar 17, 2019

I am implementing copy link file

Here's a problem:

  1. Deno does not have API to update files creation time now. Feature Request: Deno.utimes() api deno#1948
  2. Deno does not have an API to delete the link file Deno.remove() can not remove symlink file deno#1947

@axetroy axetroy changed the title feat: add copy/copySync for fs modules [WIP] feat: add copy/copySync for fs modules Mar 18, 2019
@axetroy axetroy changed the title [WIP] feat: add copy/copySync for fs modules [WIP] feat(fs): add copy/copySync for fs modules May 1, 2019
@axetroy axetroy changed the title [WIP] feat(fs): add copy/copySync for fs modules feat(fs): add copy/copySync May 15, 2019
@axetroy
Copy link
Contributor Author

axetroy commented May 15, 2019

/cc @ry ready for review

fs/copy.ts Outdated Show resolved Hide resolved
fs/copy_test.ts Show resolved Hide resolved
fs/copy_test.ts Outdated Show resolved Hide resolved
fs/copy_test.ts Outdated Show resolved Hide resolved
fs/copy_test.ts Outdated Show resolved Hide resolved
fs/copy_test.ts Outdated Show resolved Hide resolved
fs/copy_test.ts Outdated Show resolved Hide resolved
@axetroy
Copy link
Contributor Author

axetroy commented May 16, 2019

By the way

Because the test files are too large and difficult to review.

Is it possible to separate synchronous and asynchronous tests?

// copy_test.ts
import "./copy_async_test.ts"
import "./copy_sync_test.ts"

@ry
Copy link
Member

ry commented May 16, 2019

@axetroy I don't mind big files. I'd prefer you keep related code together. But I leave it up to you.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice work!

@ry ry merged commit ab5b088 into denoland:master May 16, 2019
@axetroy axetroy deleted the copy branch May 17, 2019 01:41
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants