Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test runner file matcher should walk as little as possible #576

Closed
nayeemrmn opened this issue Aug 30, 2019 · 2 comments · Fixed by #617
Closed

Test runner file matcher should walk as little as possible #576

nayeemrmn opened this issue Aug 30, 2019 · 2 comments · Fixed by #617

Comments

@nayeemrmn
Copy link
Contributor

nayeemrmn commented Aug 30, 2019

If I run deno -A https://deno.land/std/testing/runner.ts projects/deno_std/fmt/sprintf_test.ts, it walks the whole directory tree from CWD and takes a really long time. Obviously no walking should be done in this case - sound easy enough.

Ideally though, deno test projects/deno_std/fmt/*_test.ts would only walk projects/deno_std/fmt. At that point you'd want to extract a magical glob expansion utility in //fs.

@bartlomieju
Copy link
Member

Yeah it makes sense. I'll update the test runner

@bartlomieju
Copy link
Member

I got caught up in other work, if someone wants to tackle that feel free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants