Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(encoding/csv): remove ColumnOptions #2536

Merged
merged 1 commit into from
Aug 25, 2022
Merged

feat(encoding/csv): remove ColumnOptions #2536

merged 1 commit into from
Aug 25, 2022

Conversation

timreichen
Copy link
Contributor

  • removes ColumnOptions

@timreichen timreichen mentioned this pull request Aug 19, 2022
Closed
6 tasks
kt3k
kt3k approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k
Copy link
Member

kt3k commented Aug 25, 2022

We removed parse option from ColumnOptions in #1724. Since then this interface isn't meaningful anymore. This change makes sense to me.

@kt3k kt3k merged commit 3641524 into denoland:main Aug 25, 2022
@kt3k kt3k mentioned this pull request Sep 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timreichen @kt3k