Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(testing): update snapshot testing expectations #4416

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Feb 29, 2024

The string patterns for indicating output during test executions have been changed in denoland/deno#22611, and snapshot test cases are affected by that change. This PR updates the expectations of these test cases to pass CI with Deno canary.

This PR also disables CI for v1.x because it can't pass with those versions.

@kt3k kt3k changed the title chore(test): update snapshot testing expectations chore(testing): update snapshot testing expectations Feb 29, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@kt3k kt3k merged commit 45f7a6b into denoland:main Feb 29, 2024
9 checks passed
@kt3k kt3k deleted the chore-update-snapshot-test-expectations branch February 29, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants