Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation(yaml): cleanup schema exports #4566

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Apr 10, 2024

Previously, core, def, extended, json and failsafe constants were exported from their source files. However, the same symbols were exported as CORE_SCHEMA, DEFAULT_SCHEMA, EXTENDED_SCHEMA, JSON_SCHEMA, and FAILSAFE_SCHEMA were exported elsewhere, which were the same symbols, respectively. See https://jsr.io/@std/yaml/doc. This change uses the uppercase snake case names, which is the appropriate casing for constants.

@iuioiua iuioiua requested a review from kt3k as a code owner April 10, 2024 07:35
@github-actions github-actions bot added the yaml label Apr 10, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM

@iuioiua iuioiua merged commit 7cef1d9 into main Apr 10, 2024
11 checks passed
@iuioiua iuioiua deleted the deprecate-yaml-schemas branch April 10, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants