Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bytes): update API doc of lastIndexOfNeedle #4665

Merged
merged 1 commit into from
May 2, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented May 2, 2024

  • Clarifies the description of the default value of start param (lastIndexOfNeedle)
  • Fixes an example return value

@kt3k kt3k requested a review from iuioiua May 2, 2024 05:45
@github-actions github-actions bot added the bytes label May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.36%. Comparing base (8c9e96c) to head (dc37265).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4665   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files         477      477           
  Lines       37334    37334           
  Branches     5325     5325           
=======================================
  Hits        34109    34109           
  Misses       3164     3164           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k merged commit 1cfd39c into denoland:main May 2, 2024
12 checks passed
@kt3k kt3k deleted the update-byte-last-index-of-needle-doc branch May 2, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants