Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make CI config DRY #470

Merged
merged 16 commits into from
May 31, 2019
6 changes: 6 additions & 0 deletions .ci/template.common.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
parameters:
exe_suffix: ""

steps:
- bash: deno${{ parameters.exe_suffix }} run --allow-run --allow-write --allow-read format.ts --check
- bash: deno${{ parameters.exe_suffix }} run --allow-run --allow-net --allow-write --allow-read --config=tsconfig.test.json test.ts
5 changes: 5 additions & 0 deletions .ci/template.linux.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
steps:
- bash: npm install eslint typescript@$(TS_VERSION) @typescript-eslint/eslint-plugin @typescript-eslint/parser eslint-config-prettier
- template: ./template.unix.yml
- bash: npx eslint **/*.ts --max-warnings=0
- template: ./template.common.yml
6 changes: 6 additions & 0 deletions .ci/template.mac.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
steps:
- bash: npm install -g functional-red-black-tree
- bash: npm -g install eslint typescript@$(TS_VERSION) @typescript-eslint/eslint-plugin @typescript-eslint/parser eslint-config-prettier
- template: ./template.unix.yml
- bash: eslint **/*.ts --max-warnings=0
- template: ./template.common.yml
3 changes: 3 additions & 0 deletions .ci/template.unix.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
steps:
- bash: curl -L https://deno.land/x/install/install.sh | sh -s $(DENO_VERSION)
- bash: echo '##vso[task.prependpath]$(HOME)/.deno/bin/'
8 changes: 8 additions & 0 deletions .ci/template.windows.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
steps:
- bash: npm install eslint typescript@$(TS_VERSION) @typescript-eslint/eslint-plugin @typescript-eslint/parser eslint-config-prettier
- powershell: iwr https://deno.land/x/install/install.ps1 -out install.ps1; .\install.ps1 $(DENO_VERSION)
- bash: echo "##vso[task.prependpath]C:\Users\VssAdministrator\.deno\\bin"
- bash: npx eslint **/*.ts --max-warnings=0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the eslint be moved to common?

Copy link
Member Author

@bartlomieju bartlomieju May 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it's run with npx on Linux and Windows, but not on Mac. I tried running it with npx under Mac as well, but there's not npx

- template: ./template.common.yml
parameters:
exe_suffix: ".exe"
23 changes: 3 additions & 20 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,39 +2,22 @@ variables:
DENO_VERSION: "v0.7.0"
TS_VERSION: "3.4.5"

# TODO DRY up the jobs
# TODO Try to get eslint to run under Deno, like prettier
jobs:
- job: "Linux"
pool:
vmImage: "Ubuntu-16.04"
steps:
- script: npm install eslint typescript@$(TS_VERSION) @typescript-eslint/eslint-plugin @typescript-eslint/parser eslint-config-prettier
- script: curl -L https://deno.land/x/install/install.sh | sh -s $(DENO_VERSION)
- script: echo '##vso[task.prependpath]$(HOME)/.deno/bin/'
- script: npx eslint **/*.ts --max-warnings=0
- script: deno run --allow-run --allow-write --allow-read format.ts --check
- script: deno run --allow-run --allow-net --allow-write --allow-read --config=tsconfig.test.json test.ts
- template: .ci/template.linux.yml

- job: "Mac"
pool:
vmImage: "macOS-10.13"
steps:
- script: npm install -g functional-red-black-tree
- script: npm install -g eslint typescript@$(TS_VERSION) @typescript-eslint/eslint-plugin @typescript-eslint/parser eslint-config-prettier
- script: curl -L https://deno.land/x/install/install.sh | sh -s $(DENO_VERSION)
- script: echo '##vso[task.prependpath]$(HOME)/.deno/bin/'
- script: eslint **/*.ts --max-warnings=0
- script: deno run --allow-run --allow-write --allow-read format.ts --check
- script: deno run --allow-run --allow-net --allow-write --allow-read --config=tsconfig.test.json test.ts
- template: .ci/template.mac.yml

- job: "Windows"
pool:
vmImage: "vs2017-win2016"
steps:
- bash: npm install eslint typescript@$(TS_VERSION) @typescript-eslint/eslint-plugin @typescript-eslint/parser eslint-config-prettier
- powershell: iwr https://deno.land/x/install/install.ps1 -out install.ps1; .\install.ps1 $(DENO_VERSION)
- bash: echo "##vso[task.prependpath]C:\Users\VssAdministrator\.deno\\bin"
- bash: npx eslint **/*.ts --max-warnings=0
- bash: deno.exe run --allow-run --allow-write --allow-read format.ts --check
- bash: deno.exe run --allow-run --allow-net --allow-write --allow-read --config=tsconfig.test.json test.ts
- template: .ci/template.windows.yml