Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(internal): cleanup buildMessage() #4705

Merged
merged 3 commits into from
May 12, 2024
Merged

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented May 10, 2024

For improved maintainability.

@iuioiua iuioiua requested a review from kt3k as a code owner May 10, 2024 01:08
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.48%. Comparing base (c53ca87) to head (086f4ed).

Files Patch % Lines
internal/build_message.ts 85.71% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4705   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files         477      477           
  Lines       37273    37270    -3     
  Branches     5316     5316           
=======================================
- Hits        34098    34096    -2     
+ Misses       3119     3118    -1     
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua merged commit ea70808 into main May 12, 2024
12 checks passed
@iuioiua iuioiua deleted the clean-build-message branch May 12, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants