Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(media-types): polish documentation #4731

Merged
merged 1 commit into from
May 15, 2024
Merged

docs(media-types): polish documentation #4731

merged 1 commit into from
May 15, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented May 15, 2024

Towards #4730

@iuioiua iuioiua requested a review from kt3k as a code owner May 15, 2024 02:15
* getCharset("application/foo"); // undefined
* getCharset("application/news-checkgroups"); // "US-ASCII"
* getCharset("application/news-checkgroups; charset=UTF-8"); // "UTF-8"
* assertEquals(getCharset("text/plain"), "UTF-8");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I wonder whether having assertions within examples is the best solution for what examples aim to achieve. The pro is that it guarantees that examples are correct. The cons are a slight reduction in readability and an extra dependency. I'm happy to hear other's thoughts.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (b32ab88) to head (3766f0b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4731      +/-   ##
==========================================
+ Coverage   91.44%   91.88%   +0.43%     
==========================================
  Files         480      482       +2     
  Lines       37318    41211    +3893     
  Branches     5316     5316              
==========================================
+ Hits        34126    37865    +3739     
- Misses       3136     3289     +153     
- Partials       56       57       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k changed the title docs(media_types): polish documentation docs(media-types): polish documentation May 15, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@iuioiua iuioiua merged commit 1271a7f into main May 15, 2024
13 checks passed
@iuioiua iuioiua deleted the doc-media-types branch May 15, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants