Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(media-types): minor cleanups #4743

Merged
merged 1 commit into from
May 16, 2024
Merged

refactor(media-types): minor cleanups #4743

merged 1 commit into from
May 16, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented May 15, 2024

Minor cleanups and logic improvements. Overall, this was already quite a well-writtten and thorough package.

Towards #4730

@iuioiua iuioiua requested a review from kt3k as a code owner May 15, 2024 23:46
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (aa35b35) to head (38312fd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4743      +/-   ##
==========================================
- Coverage   91.89%   91.88%   -0.01%     
==========================================
  Files         484      484              
  Lines       41296    41288       -8     
  Branches     5319     5317       -2     
==========================================
- Hits        37947    37939       -8     
  Misses       3292     3292              
  Partials       57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 6c77972 into main May 16, 2024
12 checks passed
@iuioiua iuioiua deleted the clean-media-types branch May 16, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants