Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(uuid): factor out common symbols into common module #4749

Merged
merged 1 commit into from
May 16, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented May 16, 2024

This PR moves NIL_UUID into uuid/constants.ts and the remaining symbols implemented in mod.ts into uuid/common.ts.

Towards #4748

@iuioiua iuioiua requested a review from kt3k as a code owner May 16, 2024 06:00
@github-actions github-actions bot added the uuid label May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (aa35b35) to head (da66ddb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4749   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         484      485    +1     
  Lines       41296    41300    +4     
  Branches     5319     5319           
=======================================
+ Hits        37947    37951    +4     
  Misses       3292     3292           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to export common utils from @std/uuid/common. LGTM

@iuioiua iuioiua merged commit 89d95a5 into main May 16, 2024
12 checks passed
@iuioiua iuioiua deleted the uuid-common branch May 16, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants