-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Cargo binding lib #475
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afinch7
force-pushed
the
cargo_binding_plugin
branch
2 times, most recently
from
May 31, 2019 18:31
11a9206
to
dae0c0a
Compare
ry
reviewed
May 31, 2019
cargo/mod.ts
Outdated
// TODO(afinch7) make DL_PATH_CARGO_LOAD optional once we can load libs via url | ||
// and add default url to use here. | ||
const dlib = dlopen(env().DL_PATH_CARGO_LOAD); | ||
const cargoBuildOp = dlib.loadFn("cargo_build"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This is working with tests and all instructions if you want to test:
If everything is setup correctly it should automatically build the test binding and then run tests on it. |
afinch7
force-pushed
the
cargo_binding_plugin
branch
3 times, most recently
from
June 3, 2019 19:50
a262f70
to
c627df0
Compare
afinch7
force-pushed
the
cargo_binding_plugin
branch
from
June 29, 2019 22:08
466297c
to
908a885
Compare
inverted-capital
pushed a commit
to dreamcatcher-tech/napps
that referenced
this pull request
Oct 24, 2024
Please pay attention to the migration script, as it's responsible for migrating all items and votes. I've also changed all instances of `monotonicUlid()` to `ulid()` at there appears to be a bug that prevents `monotonicUlid()` from respecting the `seedTime` parameter. The migration can be simulated as follows: 1. Switch to **main** branch. 2. Run `deno run db:reset`. 3. Run `deno run db:seed`. 4. Run `deno task start` and navigate to `http://localhost:8000`. 6. Vote some items. 7. Note the voted items and the order of the items feed. 8. Switch to **ulid-items** branch. 9. Run `deno run db:migrate`. 10. Run `deno task start` and navigate to `http://localhost:8000`. 11. Check that the voted items and the order of the items feed are identical to those previously noted. Closes denoland#475 Closes denoland#476
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at a cargo binding based on the WIP native binding api in denoland/deno#2385
This is intended as a bootstrapping tool for other native bindings.
Example usage:
This should work on any machine that has at least a version of rustc installed.