Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundle loader #480

Merged
merged 5 commits into from
Jun 10, 2019
Merged

Add bundle loader #480

merged 5 commits into from
Jun 10, 2019

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Jun 5, 2019

Related to denoland/deno#2357.

I am working on adding bundles to Deno, but for the first version @ry and I discussed that we would not build loading directly into Deno, so the bundle/run.ts module can load bundles that will be generated by Deno, evaluate them and instantiate them.

There is an example bundle included in this PR, so to try locally:

deno run ./bundle/run.ts ./bundle/testdata/bundle.js

I need to add tests before this is ready for merging.

@kitsonk kitsonk changed the title [WIP] Add bundle loader Add bundle loader Jun 6, 2019
@kitsonk kitsonk marked this pull request as ready for review June 6, 2019 03:08
@kitsonk
Copy link
Contributor Author

kitsonk commented Jun 8, 2019

@ry probably want to merge this while updating to v0.8.0

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - no comments - this is cool

@ry ry merged commit fe7f6e1 into denoland:master Jun 10, 2019
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this pull request Oct 24, 2024
As we've closed the roadmap issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants