Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(text): add module doc #4812

Merged
merged 5 commits into from
May 22, 2024
Merged

docs(text): add module doc #4812

merged 5 commits into from
May 22, 2024

Conversation

dsherret
Copy link
Member

Reviewed (looks good) then added a module doc for the package.

@dsherret dsherret requested a review from littledivy May 21, 2024 16:47
@dsherret dsherret requested a review from kt3k as a code owner May 21, 2024 16:47
@github-actions github-actions bot added the text label May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.94%. Comparing base (0079ea0) to head (d7c4e5c).

Current head d7c4e5c differs from pull request most recent head 07b4927

Please upload reports for the commit 07b4927 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4812      +/-   ##
==========================================
- Coverage   91.97%   91.94%   -0.03%     
==========================================
  Files         486      486              
  Lines       41461    41355     -106     
  Branches     5360     5321      -39     
==========================================
- Hits        38133    38024     -109     
- Misses       3270     3274       +4     
+ Partials       58       57       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add text/mod.ts to _tools/check_docs.ts?

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret enabled auto-merge (squash) May 22, 2024 18:11
@dsherret dsherret merged commit 1e16dc9 into denoland:main May 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants