Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ini): add missing doc comments #4819

Merged
merged 5 commits into from
May 22, 2024
Merged

docs(ini): add missing doc comments #4819

merged 5 commits into from
May 22, 2024

Conversation

dsherret
Copy link
Member

No description provided.

@dsherret dsherret requested a review from littledivy May 21, 2024 20:03
@dsherret dsherret requested a review from kt3k as a code owner May 21, 2024 20:03
@github-actions github-actions bot added the ini label May 21, 2024
@dsherret dsherret changed the title doc(ini): add missing doc comments docs(ini): add missing doc comments May 21, 2024
@codecov Codecov
Copy link

codecov bot commented May 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (51dc36d) to head (5e9991f).
Report is 5 commits behind head on main.

❗ Current head 5e9991f differs from pull request most recent head a489ca8

Please upload reports for the commit a489ca8 to get more accurate results.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4819   +/-   ##
=======================================
  Coverage   91.94%   91.95%           
=======================================
  Files         486      486           
  Lines       41353    41355    +2     
  Branches     5321     5321           
=======================================
+ Hits        38024    38026    +2     
  Misses       3272     3272           
  Partials       57       57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

littledivy
littledivy approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lucacasonato
lucacasonato reviewed May 22, 2024
View reviewed changes
ini/ini_map.ts Outdated Show resolved Hide resolved
@dsherret @lucacasonato
Update ini/ini_map.ts
a489ca8 
Co-authored-by: Luca Casonato <lucacasonato@yahoo.com>
@dsherret dsherret merged commit 0079ea0 into denoland:main May 22, 2024
10 checks passed
@dsherret dsherret deleted the docs_ini branch May 22, 2024 17:27
@kt3k kt3k mentioned this pull request May 23, 2024
Open
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato left review comments

@littledivy littledivy littledivy approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
ini
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dsherret @lucacasonato @littledivy @iuioiua @kt3k