Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(expect): document methods and add examples #4836

Merged
merged 18 commits into from
May 23, 2024
Merged

docs(expect): document methods and add examples #4836

merged 18 commits into from
May 23, 2024

Conversation

satyarohith
Copy link
Member

  • add docs for fn module
  • add docs for expect module

@satyarohith satyarohith requested a review from kt3k as a code owner May 22, 2024 18:17
satyarohith
satyarohith commented May 22, 2024
View reviewed changes
expect/expect.ts Outdated Show resolved Hide resolved
@satyarohith satyarohith changed the title docs(expect): document methods and add expects to attain full score in JSR docs(expect): document methods and add examples May 22, 2024
@codecov Codecov
Copy link

codecov bot commented May 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.00000% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 91.98%. Comparing base (082107b) to head (4e843a4).

Files Patch % Lines
expect/expect.ts 70.83% 27 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4836   +/-   ##
=======================================
  Coverage   91.97%   91.98%           
=======================================
  Files         487      487           
  Lines       41539    41564   +25     
  Branches     5365     5365           
=======================================
+ Hits        38207    38232   +25     
  Misses       3274     3274           
  Partials       58       58

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satyarohith satyarohith enabled auto-merge (squash) May 22, 2024 20:57
iuioiua
iuioiua previously requested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add ../expect/mod.ts to the doc checker?

kt3k
kt3k reviewed May 23, 2024
View reviewed changes
expect/expect.ts
@@ -1,6 +1,9 @@
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
// This module is browser compatible.
// Copyright 2019 Allain Lalonde. All rights reserved. ISC License.
// Copyright (c) Meta Platforms, Inc. and affiliates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@satyarohith satyarohith disabled auto-merge May 23, 2024 07:41
@satyarohith satyarohith requested review from kt3k and iuioiua May 23, 2024 09:01
kt3k
kt3k approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Satya!

expect/expect.ts Outdated Show resolved Hide resolved
@kt3k kt3k mentioned this pull request May 23, 2024
Open
38 tasks
@satyarohith @kt3k
Update expect/expect.ts
4e843a4 
Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
@satyarohith satyarohith dismissed iuioiua’s stale review May 23, 2024 11:20

review addressed

@satyarohith satyarohith merged commit caac76f into main May 23, 2024
11 checks passed
@satyarohith satyarohith deleted the document_expect_module branch May 23, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@iuioiua iuioiua Awaiting requested review from iuioiua

Assignees
No one assigned
Labels
expect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satyarohith @kt3k @iuioiua