Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(url): release url@1.0.0-rc.1 #4981

Merged
merged 2 commits into from
Jun 6, 2024
Merged

chore(url): release url@1.0.0-rc.1 #4981

merged 2 commits into from
Jun 6, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jun 5, 2024

Frankly, I still think url.dirname() should probably return a string rather than URL (#4967). Nevertheless, I won't keep that as a blocker. This package looks ready to me.

Towards #4924

@iuioiua iuioiua requested a review from kt3k as a code owner June 5, 2024 22:28
@github-actions github-actions bot added the url label Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.09%. Comparing base (0ea4868) to head (f6d72e4).

Current head f6d72e4 differs from pull request most recent head 2a8f5fc

Please upload reports for the commit 2a8f5fc to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4981      +/-   ##
==========================================
+ Coverage   92.04%   92.09%   +0.04%     
==========================================
  Files         487      487              
  Lines       38766    38751      -15     
  Branches     5428     5415      -13     
==========================================
+ Hits        35682    35687       +5     
+ Misses       3027     3007      -20     
  Partials       57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k
Copy link
Member

kt3k commented Jun 6, 2024

I still think url.dirname() should probably return a string rather than URL (#4967)

url.parent() might be a better name..?

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's discuss url.dirname issue during RC

@iuioiua iuioiua enabled auto-merge (squash) June 6, 2024 19:57
@iuioiua iuioiua merged commit 628814e into main Jun 6, 2024
10 checks passed
@iuioiua iuioiua deleted the url-rc-1 branch June 6, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants