Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(async): stop exporting ERROR_WHILE_MAPPING_MESSAGE #5041

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 14, 2024

part of #5001

We usually don't export error message string as string constant value. Also exporting this doesn't look useful. I suggest we should remove this export.

@github-actions github-actions bot added the async label Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (22b4d03) to head (ff5ec61).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5041   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         487      487           
  Lines       38796    38796           
  Branches     5433     5433           
=======================================
  Hits        35760    35760           
  Misses       2981     2981           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kt3k kt3k merged commit 3a93085 into denoland:main Jun 14, 2024
12 checks passed
@kt3k kt3k deleted the remove-error-message-constant branch June 14, 2024 10:15
@iuioiua iuioiua changed the title BREAKING(async): stop exporting ERROR_WHILE_MAPPING_MESSAGE BREAKING(async): stop exporting ERROR_WHILE_MAPPING_MESSAGE Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants