refactor(http): remove dead code and improve UserAgent testing
#5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
commented
Jun 24, 2024
Comment on lines
-150
to
-157
| if (Array.isArray(str1)) { | ||
| for (const el of str1) { | ||
| if (lowerize(el) === lowerize(str2)) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } |
There was a problem hiding this comment.
str1 is always string with all has usages. This if-block is dead code.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5120 +/- ##
==========================================
+ Coverage 92.72% 92.87% +0.14%
==========================================
Files 479 479
Lines 38305 38291 -14
Branches 5394 5399 +5
==========================================
+ Hits 35520 35562 +42
+ Misses 2732 2676 -56
Partials 53 53 ☔ View full report in Codecov by Sentry. |
kt3k
commented
Jun 24, 2024
kt3k
commented
Jun 24, 2024
iuioiua
suggested changes
Jun 24, 2024
http/user_agent.ts
Outdated
| } | ||
| return false; | ||
| } | ||
| function has(str1: string, str2: string): boolean { | ||
| return lowerize(str2).indexOf(lowerize(str1)) !== -1; |
iuioiua
changed the title
UserAgent testing
iuioiua
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some dead code and improves typings in
http/user_agent.ts, and also adds test cases which exercise uncovered lines.towards #3713