Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(testing): improve error messages in mock module #5549

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jul 26, 2024

Improves casing and punctuation.

@iuioiua iuioiua requested a review from kt3k as a code owner July 26, 2024 00:52
@iuioiua iuioiua enabled auto-merge (squash) July 26, 2024 00:52
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (b095901) to head (53b822b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5549   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files         465      465           
  Lines       37770    37772    +2     
  Branches     5579     5579           
=======================================
+ Hits        36443    36445    +2     
  Misses       1285     1285           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 1eb559f into main Jul 26, 2024
17 checks passed
@iuioiua iuioiua deleted the testing-mock-error-msgs branch July 26, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants