-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(async): abortableAsyncIterable()
should call .return()
on the generator once aborted
#5560
Conversation
…erator once aborted
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5560 +/- ##
=======================================
Coverage 96.48% 96.48%
=======================================
Files 465 465
Lines 37759 37764 +5
Branches 5579 5580 +1
=======================================
+ Hits 36432 36437 +5
Misses 1285 1285
Partials 42 42 ☔ View full report in Codecov by Sentry. |
abortableAsyncIterable()
should call .return()
on the generator once aborted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay, and thank you for contributing! LGTM.
I realise that |
Ach yes, there is missing part but it's not just that. I created new PR that handles this one. |
Fixes #3518