Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): remove broken variable in favour of loop label #5602

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

timreichen
Copy link
Contributor

  • replaces broken boolean and just continues the loop directly by adding loop label.

@timreichen timreichen requested a review from kt3k as a code owner August 1, 2024 11:12
@github-actions github-actions bot added the cli label Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (577fd9a) to head (ec1f33b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5602   +/-   ##
=======================================
  Coverage   96.37%   96.38%           
=======================================
  Files         466      466           
  Lines       37526    37553   +27     
  Branches     5528     5537    +9     
=======================================
+ Hits        36167    36195   +28     
+ Misses       1317     1316    -1     
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua enabled auto-merge (squash) August 1, 2024 11:22
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@iuioiua iuioiua merged commit b5181c1 into denoland:main Aug 1, 2024
11 checks passed
@timreichen timreichen deleted the cli-remove-broken branch August 17, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants