Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): handle wrong request method correctly #5643

Merged
merged 2 commits into from
Aug 7, 2024
Merged

fix(http): handle wrong request method correctly #5643

merged 2 commits into from
Aug 7, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Aug 6, 2024

Previously, the file-server module handled all requests with non-GET and non-HEAD methods the same as GET and HEAD methods, when they shouldn't have. Now, such methods cause a HTTP 405 status to be served.

@iuioiua iuioiua requested a review from kt3k as a code owner August 6, 2024 13:12
@iuioiua iuioiua enabled auto-merge (squash) August 6, 2024 13:12
@github-actions github-actions bot added the http label Aug 6, 2024
@iuioiua iuioiua changed the title fix(http): handle incorrect method fix(http): handle wrong request method correctly Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (889a63d) to head (5918dbd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5643   +/-   ##
=======================================
  Coverage   96.44%   96.45%           
=======================================
  Files         468      468           
  Lines       38219    38226    +7     
  Branches     5542     5549    +7     
=======================================
+ Hits        36862    36869    +7     
  Misses       1315     1315           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

http/file_server.ts Outdated Show resolved Hide resolved
@iuioiua iuioiua requested a review from kt3k August 6, 2024 14:21
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit d682c6b into main Aug 7, 2024
13 checks passed
@iuioiua iuioiua deleted the http-method branch August 7, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants