Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(encoding): cleanup base32 tests #5665

Merged
merged 2 commits into from
Aug 10, 2024
Merged

test(encoding): cleanup base32 tests #5665

merged 2 commits into from
Aug 10, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Aug 9, 2024

These are clearer and use official test vectors.

@iuioiua iuioiua requested a review from kt3k as a code owner August 9, 2024 11:49
@iuioiua iuioiua enabled auto-merge (squash) August 9, 2024 11:49
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (d5e3180) to head (6fc90f5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5665   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files         476      475    -1     
  Lines       38475    38464   -11     
  Branches     5584     5584           
=======================================
- Hits        37033    37023   -10     
+ Misses       1400     1399    -1     
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 36cafcf into main Aug 10, 2024
13 checks passed
@iuioiua iuioiua deleted the encoding-base32 branch August 10, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants