Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(crypto): remove old unused _fnv folder #5716

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented Aug 18, 2024

No description provided.

@timreichen timreichen requested a review from kt3k as a code owner August 18, 2024 19:43
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (75cb767) to head (2eb4c21).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5716      +/-   ##
==========================================
- Coverage   96.26%   96.25%   -0.01%     
==========================================
  Files         477      473       -4     
  Lines       38512    38395     -117     
  Branches     5589     5582       -7     
==========================================
- Hits        37072    36956     -116     
+ Misses       1398     1397       -1     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k
Copy link
Member

kt3k commented Aug 19, 2024

This change itself makes sense, but it looks like crypto/_fnv/mod.ts itself doesn't seem being used now (Probably it became unused after #4515 ). Can you instead remove crypto/_fnv dir instead?

@timreichen timreichen changed the title refactor(crypto): make buf argument required refactor(crypto): remove _fnv Aug 19, 2024
@timreichen
Copy link
Contributor Author

This change itself makes sense, but it looks like crypto/_fnv/mod.ts itself doesn't seem being used now (Probably it became unused after #4515 ). Can you instead remove crypto/_fnv dir instead?

done

@iuioiua iuioiua changed the title refactor(crypto): remove _fnv refactor(crypto): remove old unused _fnv folder Aug 19, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot, Yoshiya and Tim! Surprised I didn't notice this myself.

@iuioiua iuioiua merged commit 06da501 into denoland:main Aug 19, 2024
15 checks passed
@timreichen timreichen deleted the crypto-make-buf-argument-required branch August 20, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants