Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): rename DumperState methods #5738

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

timreichen
Copy link
Contributor

Changes
This PR renames DumperState methods fro write*() to stringify*()

Reasoning
#5683 removed the dump property. All these functions now turn passed data into a string and return it.

@timreichen timreichen requested a review from kt3k as a code owner August 20, 2024 07:35
@github-actions github-actions bot added the yaml label Aug 20, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add explicit return types?

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.28%. Comparing base (d6fde64) to head (6e7cd31).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5738      +/-   ##
==========================================
- Coverage   96.28%   96.28%   -0.01%     
==========================================
  Files         474      474              
  Lines       38387    38383       -4     
  Branches     5578     5578              
==========================================
- Hits        36962    36957       -5     
- Misses       1383     1384       +1     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timreichen timreichen requested a review from iuioiua August 20, 2024 07:38
@iuioiua iuioiua enabled auto-merge (squash) August 20, 2024 07:41
@iuioiua iuioiua merged commit 6c70fa9 into denoland:main Aug 20, 2024
16 checks passed
@timreichen timreichen deleted the yaml-rename-functions branch August 20, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants